Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Css property name issue #21368

Merged
merged 6 commits into from
Feb 25, 2019
Merged

Css property name issue #21368

merged 6 commits into from
Feb 25, 2019

Conversation

amol2jcommerce
Copy link
Contributor

Description (*)

Magento 2.3.0

Fixed Issues (if relevant)

  1. CSS Property name issue #21365: CSS Property name issue

Manual testing scenarios (*)

  1. Magento_Swatches _module.less file

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Nainesh and others added 6 commits January 23, 2019 02:59
'Fixes-for-customer-login-page-input-field' :: On customer login page…
f669a4d 
… input field are short width on tablet view
Merge pull request #1 from amol2jcommerce/2.3-develop-PR-port-20369
ac8b808 
[Forwardport] 'Fixes-for-customer-login-page-input-field' :: On customer login page…
'Fixes-for-customer-login-page-input-field' :: On customer login page…
40a6274 
… input field are short width on tablet view
Merge pull request #8 from amol2jcommerce/2.3-develop-PR-port-20369
2123f2f 
[Forwardport] 'Fixes-for-customer-login-page-input-field' :: On customer login page…
CSS-Property-name-issue
9a0c504
unwanted changes reverted CSS-Property-name-issue
a68e815
@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Feb 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4347 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Feb 25, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit a68e815 into magento:2.3-develop Feb 25, 2019
@ghost
Copy link

ghost commented Feb 25, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 25, 2019
@sivaschenko
ENGCOM-4347: Css property name issue #21368
c81aa8d
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Cleanup Partner: Two Jay partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@amol2jcommerce @magento-engcom-team @VladimirZaets